Skip to content

[SYCL][CI] Create a single target for test utilities #20417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 29, 2025
Merged

[SYCL][CI] Create a single target for test utilities #20417

merged 7 commits into from
Oct 29, 2025

Conversation

@KornevNikita
Copy link
Contributor

@KornevNikita KornevNikita commented Oct 21, 2025 •
edited
Loading

No description provided.

@KornevNikita
[SYCL][CI] Move test utilities instal to sh
6c45fab 
I guess it's not possible to create a single cmake target to install all
required test utilities since there is no root CMakeLists.txt. Therefore
moving these steps to the shell script.
@KornevNikita KornevNikita mentioned this pull request Oct 21, 2025
Closed
@KornevNikita KornevNikita changed the title [SYCL][CI] Move test utilities instal to sh [SYCL][CI] Move test utilities install to sh Oct 21, 2025
lukaszstolarczuk
lukaszstolarczuk reviewed Oct 21, 2025
View reviewed changes
@KornevNikita KornevNikita requested a review from a team as a code owner October 24, 2025 13:09
@KornevNikita KornevNikita reopened this Oct 27, 2025
@KornevNikita KornevNikita changed the title [SYCL][CI] Move test utilities install to sh [SYCL][CI] Create a single target for test utilities Oct 27, 2025
jsji
jsji reviewed Oct 27, 2025
View reviewed changes
@github-actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

@KornevNikita KornevNikita requested a review from jsji October 28, 2025 18:08
jsji
jsji approved these changes Oct 28, 2025
View reviewed changes
Copy link
Contributor

@jsji jsji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@KornevNikita
Copy link
Contributor Author

@intel/llvm-gatekeepers could you please merge

@steffenlarsen steffenlarsen merged commit 1e0c1f4 into sycl Oct 29, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk left review comments

@jsji jsji jsji approved these changes

@sarnex sarnex sarnex approved these changes

@cperkinsintel cperkinsintel Awaiting requested review from cperkinsintel cperkinsintel is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@KornevNikita @jsji @sarnex @lukaszstolarczuk @steffenlarsen